refactor: rename and modularize resources-get command#34
Merged
Conversation
0dc5d72 to
13f945a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR performs a major architectural refactor of the resource acquisition logic. The monolithic
ConfiguratorGetResourcesCommandhas been transformed into a clean Orchestrator, delegating specific responsibilities to specialized processors, services, and runners.Key Changes:
Renaming & Organization: Renamed
ConfiguratorGetResourcesCommandtoResourcesGetCommandfor better semantics. Moved the command and its dependencies into a dedicated modular directory:lib/src/commands/resources/.Logic Extraction (SOLID):
ApplicationDataFetcher: Handles API interactions and initial data validation.ThemeConfigProcessor: Manages JSON configuration mapping and asset migration.AssetProcessor: Handles binary downloads (icons, splash screens).TranslationProcessor: Manages Localization logic.CertificateProcessor: Handles local filesystem operations for SSL certs.LocalConfigProcessor: Manages local build cache and environment file generation.ExternalGeneratorRunner: Orchestrates systemmakeprocess execution.Performance & Stability:
Replaced blocking synchronous I/O calls with non-blocking asynchronous alternatives.
Improved process handling by properly awaiting
stdout/stderrstreams.Type Safety: Eliminated
dynamictypes in favor of explicit DTOs (SplashAssetDto,LaunchAssetsEnvelopeDto, etc.).Clean Code:
Introduced
ResourcesContextto encapsulate command state.Implemented
CommandHelpFormatterfor consistent CLI help output.Standardized import ordering and removed redundant comments.
Type of Change