Skip to content

Add type.mmreg, dls and xmf hexpat #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

rsp4jack
Copy link

@rsp4jack rsp4jack commented Apr 4, 2025

This PR adds type.mmreg module, DLS (DownLoadable Sounds) amd (M)XMF ((Mobile) eXtensible Music Format).

wav.hexpat is also modified to use type.mmreg.

@rsp4jack rsp4jack changed the title Add type.mmreg, dls and wav hexpat Add type.mmreg, dls and smf hexpat Apr 12, 2025
@rsp4jack rsp4jack changed the title Add type.mmreg, dls and smf hexpat Add type.mmreg, dls and xmf hexpat Apr 12, 2025
@rsp4jack rsp4jack marked this pull request as draft April 12, 2025 08:56
@WerWolv
Copy link
Owner

WerWolv commented May 10, 2025

Thanks a lot! Looks great for the most part.
There's one issue though with the placement of the files. The libraries in the includes folder are meant to be generic and to be included by many different patterns. So pattern specific data types don't really belong in there. Instead, since your patterns depend on multiple files, they should probably all go in a new sub-directory in the patterns folder so they can be downloaded and used all at once

@rsp4jack
Copy link
Author

@WerWolv the mmreg.pat is ported from mmreg.h in Windows SDK, standing for "Multimedia Registry". It contains the wFormat tags, WAVEFORMAT structs and something else.
Actually it is quite generic, but your suggestions make sense.

@WerWolv
Copy link
Owner

WerWolv commented May 10, 2025

Yeah, we don't have a proper way right now to have types and constants stored in some shared place. Maybe ultimately a new library would be good for that.
The types library, in any case, is meant for really standard types that a lot of different formats might use. Think types for parsing IP addresses, GUIDs, Fixed Point numbers and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants