Make external modded pattern file reload work. Make ext-modded data reload safe. #2457
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shewitt-au
changed the title
shewitt-au
changed the title
… into reload_fixes
… into reload_fixes
… into reload_fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
If I modify a pattern externally I get an option to reoad it. Taking this option does nothing. The code in
FileProvideralso handlles reloads, but not in a thread-safe way.Implementation description
Hooked up the missing bits in the pattern editor. For the file provider (and the pattern editor) I used
TaskManager::doLaterfrom theChangeTrackercallback (called from a worker thread) to get the operation handled by the UI thread. Not doing this opens the possibility for unsynchronised access to state by multiple threads.