Skip to content

Harden StormDNS boundary guard#40

Open
AmirrezaFarnamTaheri wants to merge 1 commit into
WhiteDNS:mainfrom
AmirrezaFarnamTaheri:stormdns-boundary-guard
Open

Harden StormDNS boundary guard#40
AmirrezaFarnamTaheri wants to merge 1 commit into
WhiteDNS:mainfrom
AmirrezaFarnamTaheri:stormdns-boundary-guard

Conversation

@AmirrezaFarnamTaheri

@AmirrezaFarnamTaheri AmirrezaFarnamTaheri commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Validate both base and head refs before checking StormDNS boundary changes.
  • Guard .gitmodules alongside third_party/StormDNS because submodule metadata changes affect the upstream engine boundary.
  • Stop masking git diff failures in the boundary script.
  • Let allow-stormdns-upstream bypass only intentional upstream-change detections, not script/ref failures.
  • Update the upstream policy doc to include guarded submodule metadata.

Verification

Validate both base and head refs before checking upstream engine changes.

Treat third_party/StormDNS and .gitmodules as guarded upstream boundary surfaces.

Let the allow-stormdns-upstream label override only intentional upstream-change detections while preserving hard failures for script or ref errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant