feat: add TalkBack/screen-reader accessibility to WhiteDNS#41
Merged
iampedii merged 19 commits intoMay 18, 2026
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Hi Dani, This is a really valuable change. I really appreciate the effort you’ve put into improving accessibility and making the app more usable for people with disabilities. Great work getting this done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds comprehensive TalkBack/screen-reader accessibility support to WhiteDNS. The implementation follows Android accessibility best practices by adding semantic content descriptions to all interactive UI elements, enabling users with visual impairments to navigate and operate the application effectively.
Technical Approach
We use the idiomatic Compose pattern for accessibility:
Modifier.semantics { contentDescription = ... }applied directly to clickable containers. TalkBack reads the semantics node of the focused container, making this the correct and reliable approach for content description assignment.Changes
String Resources
app/src/main/res/values/strings.xmlapp/src/main/res/values-fa/strings.xmlUI Implementation
WhiteDnsScreen.kt:Bug Fixes
Testing
Verification steps with TalkBack enabled:
Scope
This change is purely accessibility-focused with no modifications to feature behavior or UI structure. All changes are in-place within existing composable functions without refactoring or component extraction. The implementation is forward-compatible with planned in-app language switching features.
Compatibility