Redact sensitive connection diagnostics#48
Open
poulcarlsen53 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This keeps secrets out of the places where they are easiest to leak by accident:
The diagnostics still show whether a key is configured, but they no longer copy the key itself into support logs or the clipboard.
Why
The previous diagnostics text included the full custom server encryption key, and the live connection card showed the SOCKS password in plain text. Those values can leak through screenshots, shoulder surfing, clipboard previews, keyboard clipboard history, or support snippets.
Verification
./gradlew :app:testDebugUnitTest --tests shop.whitedns.client.ui.SensitiveTextTest --no-daemon