Confirm and validate StormDNS profile imports#49
Open
poulcarlsen53 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This hardens the profile import path and the generated StormDNS TOML:
stormdns://links opened from Android now show a confirmation dialog before importingWhy
A browsable
stormdns://link previously imported and selected a profile immediately. For a DNS/proxy/VPN client, that is a risky default because a crafted link can change the server a user routes traffic through. The TOML renderer also escaped quotes and backslashes only, so control characters could produce invalid or surprising config output.Verification
./gradlew :app:testDebugUnitTest --tests shop.whitedns.client.model.WhiteDnsModelsTest --tests shop.whitedns.client.storm.StormDnsConfigRendererTest --no-daemon./gradlew :app:compileDebugSources --no-daemon