Polish app routing picker interactions#52
Open
poulcarlsen53 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.google.android.gmseven when Android will not enumerate them in the installed-app list.Why
This takes a small, user-facing slice from the open app-routing/profile UX issues, especially the selected-app ordering and system-app requests in #32. I avoided adding
QUERY_ALL_PACKAGES; the picker now exposes visible system apps where Android allows it and gives users a direct package-name escape hatch for packages that are hidden by package visibility rules.Testing
./gradlew.bat :app:testDebugUnitTest --tests shop.whitedns.client.ui.SplitTunnelAppOptionsTest --no-daemon --stacktrace./gradlew.bat :app:assembleDebug --no-daemon --stacktraceI also tried the full
:app:testDebugUnitTest :app:assembleDebugrun on Windows. It still hits the existingScanResolverChunkerTest.writePendingScanResolverFileStreamsWithoutKeepingPendingListline-ending expectation; this PR does not touch that scan writer/test path.