fix(a11y): Role.Button on all bare clickables, TextField label link, split-tunnel double-action#59
Merged
Conversation
…ls, split-tunnel double-action
- Replace split-tunnel app row .clickable + active Checkbox with
toggleable(Role.Checkbox) + Checkbox(onCheckedChange=null,
clearAndSetSemantics{}), matching the ParallelTestConfigRow pattern
- Add role=Role.Button to ConnectButton semantics block
- Add role=Role.Button to all 23 bare .clickable elements:
expand/collapse headers, icon buttons, action buttons, close/dismiss
buttons, footer link, dropdown triggers, stat cards, log buttons
- Wrap WhiteDnsTextField Column with semantics(mergeDescendants=true)
so TalkBack announces the visible FieldLabel alongside the input
- Set SectionCard icon contentDescription=null when non-collapsible
to eliminate meaningless noise for screen reader users
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
@Danialsamadi Thank you for you MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the TalkBack foundation from #45 to close the remaining WCAG 4.1.2 (Name, Role, Value — Level A) gaps found by a full audit of
WhiteDnsScreen.kt.Split-tunnel app row — replaced
.clickable+ activeCheckbox(onCheckedChange)withtoggleable(role = Role.Checkbox)+Checkbox(onCheckedChange = null, clearAndSetSemantics {}), matching theParallelTestConfigRowpattern. Previously TalkBack focused on both the row and the checkbox separately, firingonToggle()twice.ConnectButton — added
role = Role.Buttonto.semantics(mergeDescendants = true) {}so TalkBack announces "Button" on the main action element.23 bare
.clickableelements — addedrole = Role.Buttonto every custom interactive element that used.clickable {}or.clickable(enabled)without a declared role. Includes: expand/collapse headers,ProfileIconButton,CompactActionButton,ResolverActionButton,LogActionButton,SectionCardtoggle header, dropdown triggers, dismiss/close buttons for banners and dialogs, the footer Telegram link, copy-address row, and stat cards.WhiteDnsTextFieldlabel association — wrapped theColumn(FieldLabel + BasicTextField)withsemantics(mergeDescendants = true)so TalkBack announces the visible field label alongside the input field (WCAG 1.3.1 / 3.3.2).SectionCardnon-collapsible icon —contentDescriptionis nownullwhencollapsible = false, eliminating noise for screen reader users on static section headers.WCAG criteria addressed
Test plan
SectionCardheaders are not announced as interactive🤖 Generated with Claude Code