This repository was archived by the owner on Feb 11, 2023. It is now read-only.
Rewrite default urls to ./index.html#61
Open
jaredstehler wants to merge 10 commits intoWiden:masterfrom
Open
Conversation
|
I think its worth making configurable :) |
|
Original suggestion came from me and YES totally would love to have it configurable. Also I'd be totally happy to contribute the PR to modify build.js if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we need to use a
CloudFrontOriginAccessIdentityto not expose our S3 content publicly, we can't (I believe) use the S3 website endpoint as a CloudFront origin, meaning we can't use the S3 website feature which allows for default folder URLs to resolve toindex.htmlunder the hood. This PR rewrites all URI's which end in '/' to append 'index.html'.It might be nice to make this configurable; I'm willing to go down the road of updating the
build.jsto add that as a parameter if folks think this is useful enough.