Skip to content

Consolidate location text #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Consolidate location text #14

wants to merge 1 commit into from

Conversation

larsenv
Copy link

@larsenv larsenv commented May 25, 2024

This changes the function used to write location text, making it write a location to the file only once. For example, rather than writing United States each time a city is defined, it will write it once and the offset to the text will point to it. This will save 30 kb of data in the US file, but much less is saved when you compress it. I figured that this PR once @noahpistilli merges it will help bring some of the data files uncompressed to less than 0x20000 byte (is that the limit?) because luna told me that any game which uses the forecast channel is broken because of the limit. This has been tested

@larsenv larsenv closed this May 25, 2024
@larsenv larsenv reopened this May 25, 2024
@noahpistilli
Copy link
Member

I really like the idea but I don't like the implementation. There are multiple ways you can condense the code.

@larsenv
Copy link
Author

larsenv commented Jun 12, 2024

Sorry bout that, I'm not as good with the language as you are, if you want to fix it go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants