[DRAFT] MW 1.43 migration by peterdevpl · Pull Request #9 · Wikia/DynamicPageList3

peterdevpl · 2025-01-28T13:42:08Z

backported changes from the upstream repo
changed queries to work with the new pagelinks table schema
run tests on MW 1.43 & PHP 8.2

Caveats:

linkstoexternal will not work, see DPL3 doesn't support externallinks table changes on 1.41 Universal-Omega/DynamicPageList4#274 (comment)
there are some deprecations left, but I'd rather wait for the upstream to change it, so we don't diverge our fork too much

Co-authored-by: Martyna Nowicka <37370506+maaartyyynaa@users.noreply.github.com>

…2.1 (Universal-Omega#227) Updates the requirements on [mediawiki/mediawiki-phan-config](https://github.com/wikimedia/mediawiki-tools-phan) to permit the latest version. - [Release notes](https://github.com/wikimedia/mediawiki-tools-phan/releases) - [Changelog](https://github.com/wikimedia/mediawiki-tools-phan/blob/master/HISTORY.md) - [Commits](wikimedia/mediawiki-tools-phan@0.12.0...0.12.1) --- updated-dependencies: - dependency-name: mediawiki/mediawiki-phan-config dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…versal-Omega#229) Under MySQL 8 this saved 200 ms off the first run and lets subsequent runs be almost instantaneous. Co-authored-by: TehKittyCat <tehkittycat@weirdgloop.org>

…iversal-Omega#228) User->getName() falls back to the current user's IP address if there is no user name. Co-authored-by: TehKittyCat <tehkittycat@weirdgloop.org>

…id. (Universal-Omega#229)" (Universal-Omega#230) This reverts commit f66d483.

…0.0 (Universal-Omega#245) Updates the requirements on [mediawiki/mediawiki-codesniffer](https://github.com/wikimedia/mediawiki-tools-codesniffer) to permit the latest version. - [Changelog](https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/HISTORY.md) - [Commits](wikimedia/mediawiki-tools-codesniffer@v41.0.0...v42.0.0) --- updated-dependencies: - dependency-name: mediawiki/mediawiki-codesniffer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…mega#246) Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.11.0...0.12.0) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…a#242) Bumps [sqren/backport-github-action](https://github.com/sqren/backport-github-action) from 8.9.7 to 9.3.0. - [Release notes](https://github.com/sqren/backport-github-action/releases) - [Commits](sorenlouv/backport-github-action@v8.9.7...v9.3.0) --- updated-dependencies: - dependency-name: sqren/backport-github-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fixes issue Universal-Omega#226 Previously, the query selected the latest revision for each page based on the rev_timestamp, but did not consider the rev_minor_edit value until afterwards. Now it will retrieve the latest revision that satisfies the condition rev.rev_minor_edit = 0.

…} instead" (Universal-Omega#250)

…f type string is deprecated" (Universal-Omega#251)

The MediaWiki linter reports <tt> as an obsolete HTML tag on translatewiki. <code> is commonly used for the same purpose.

Sorry, I didn't notice these issues in my previous patch. 1. Put *? into "<code>". It wasn't clearly separated from the text, and it was translated incorrectly into some languages because people probably thought that it's an actual question. 2. Improve English grammar—"that" is clearer than "which" here because it's a restrictive clause, and in the end, there should be an article.

This reverts commit c15c041.

This reverts commit 91f14b6.

peterdevpl · 2025-02-10T11:27:58Z

Closing because the required changes are now in the upstream.

emkarcinos and others added 30 commits March 16, 2023 14:49

Fix usedby query returning all templates (Universal-Omega#224)

43864ad

Co-authored-by: Martyna Nowicka <37370506+maaartyyynaa@users.noreply.github.com>

Add CHANGELOG entry

67ca392

Improve the performance of rev_page subqueries by using page_id. (Uni…

f66d483

…versal-Omega#229) Under MySQL 8 this saved 200 ms off the first run and lets subsequent runs be almost instantaneous. Co-authored-by: TehKittyCat <tehkittycat@weirdgloop.org>

Don't return the viewer's IP address as %USER% if rev_actor is 0. (Un…

7966936

…iversal-Omega#228) User->getName() falls back to the current user's IP address if there is no user name. Co-authored-by: TehKittyCat <tehkittycat@weirdgloop.org>

Revert "Improve the performance of rev_page subqueries by using page_…

c2b3cbc

…id. (Universal-Omega#229)" (Universal-Omega#230) This reverts commit f66d483.

Localisation updates from https://translatewiki.net.

e4faf60

Localisation updates from https://translatewiki.net.

1ac2411

Use ci-scripts

66c441c

Localisation updates from https://translatewiki.net.

8fe7e64

Localisation updates from https://translatewiki.net.

09c15eb

Localisation updates from https://translatewiki.net.

43e389f

Localisation updates from https://translatewiki.net.

2e88480

Localisation updates from https://translatewiki.net.

92159b5

Cleanup in en.json (Universal-Omega#237)

4646f9a

Localisation updates from https://translatewiki.net.

e86e7db

Localisation updates from https://translatewiki.net.

2e568fd

Localisation updates from https://translatewiki.net.

f64459f

Fix "PHP Deprecated: Using ${var} in strings is deprecated, use {$var…

6f2834a

…} instead" (Universal-Omega#250)

Fix "PHP Deprecated: trim(): Passing null to parameter #1 ($string) o…

811467f

…f type string is deprecated" (Universal-Omega#251)

Localisation updates from https://translatewiki.net.

8d630ec

Localisation updates from https://translatewiki.net.

6fe23d7

Localisation updates from https://translatewiki.net.

6c5a5e2

Localisation updates from https://translatewiki.net.

3eead68

Localisation updates from https://translatewiki.net.

25c9fd0

amire80 and others added 10 commits September 30, 2024 12:06

Replace <tt> with <code> (Universal-Omega#289)

2fb5d55

The MediaWiki linter reports <tt> as an obsolete HTML tag on translatewiki. <code> is commonly used for the same purpose.

Localisation updates from https://translatewiki.net.

1f0a1a4

Localisation updates from https://translatewiki.net.

26b8978

PLATFORM-9844: WIP: Migration to MW 1.43 - resolved merge conflicts

c0b7bbf

PLATFORM-9844: WIP: Fixed deprecated MW imports

91f14b6

PLATFORM-9844: WIP: Rector & phpcs

c15c041

PLATFORM-9844: WIP: Fixed property accidentally removed by Rector

6f36ef7

Replace deprecated MWException (Universal-Omega#276)

ce202e2

Fix

78c39d7

peterdevpl self-assigned this Jan 28, 2025

peterdevpl and others added 16 commits January 28, 2025 15:15

PLATFORM-9844: Run PHPUnit on MW 1.43 and PHP 8.2

e377b0e

PLATFORM-9844: Run PHPUnit on MW 1.43 and PHP 8.2

5afb32c

PLATFORM-9844: WIP: Adapting to the new pagelinks table schema

98cd6d5

Localisation updates from https://translatewiki.net.

63d5a9d

Localisation updates from https://translatewiki.net.

795566e

PLATFORM-9844: Adapted DPL queries to the new pagelinks table schema

068b2f9

PLATFORM-9844: Restored GROUP BY in imageused

7a00c7a

PLATFORM-9844: Fixed handling %PAGESEL% with linksfrom

22084da

PLATFORM-9844: Fixed deduplication of linksto and linksfrom results

2891d4d

Revert "PLATFORM-9844: WIP: Rector & phpcs"

2defb88

This reverts commit c15c041.

Revert "PLATFORM-9844: WIP: Fixed deprecated MW imports"

4e36864

This reverts commit 91f14b6.

Merge remote-tracking branch 'upstream/master' into REL1_43

e80f590

PLATFORM-9844: Updated test matrix

20e2fa3

PLATFORM-9844: Bumped minimum MW to 1.42

07f5de0

PLATFORM-9844: Updated test matrix to include only PHP 8.1 and 8.2

ec8c1a6

PLATFORM-9844: Trying to fix "coverage" step in CI

70e01f2

peterdevpl closed this Feb 10, 2025

peterdevpl deleted the REL1_43 branch February 10, 2025 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] MW 1.43 migration#9

[DRAFT] MW 1.43 migration#9
peterdevpl wants to merge 93 commits intomasterfrom
REL1_43

peterdevpl commented Jan 28, 2025 •

edited

Loading

Uh oh!

peterdevpl commented Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

peterdevpl commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterdevpl commented Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

peterdevpl commented Jan 28, 2025 •

edited

Loading