Feature/login formular #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesbesdria
requested changes
Mar 31, 2025
TeddyAgt
requested changes
Apr 10, 2025
TeddyAgt
requested changes
Apr 22, 2025
TeddyAgt
requested changes
Apr 22, 2025
alesbesdria
reviewed
Apr 24, 2025
TeddyAgt
approved these changes
Apr 25, 2025
L-M-14
approved these changes
Apr 25, 2025
alesbesdria
approved these changes
Apr 25, 2025
YDrogen
requested changes
Apr 25, 2025
| @@ -19,11 +19,12 @@ node_modules | |||
|
|
|||
| # IDE - VSCode | |||
| .vscode/* | |||
| !.vscode/settings.json | |||
| # !.vscode/settings.json | |||
| req.isAuthenticated = true; | ||
| req.userId = payload.userId; | ||
| } catch (aterror) { | ||
| console.error(aterror); |
There was a problem hiding this comment.
Surtout pas ! C'est une erreur qui va arriver très souvent, et c'est normal, si on console.log, ça va seulement spam les logs
A l'échelle de centaines d'utilisateurs, tu vas très vite surcharger les fichiers de logs, et donc le stockage de ton serveur
| req.isAuthenticated = true; | ||
| req.userId = payload.userId; | ||
| } catch (rterror) { | ||
| console.error('Refresh token is invalid', rterror); |
|
|
||
| // If the refresh token is invalid, | ||
| req.isAuthenticated = false; | ||
| return; |
There was a problem hiding this comment.
Pourquoi return ? Si on arrive ici, le client qui fait la requête n'aura jamais de réponse
| return db | ||
| .selectFrom('user') | ||
| .select(['user.id', 'user.password', 'user.email']) | ||
| .where('user.email', '=', email || 'user.username ') |
| return ( | ||
| <div className='md:mx-16 md:my-24 md:h-full'> | ||
| <div className='font-title my-10 text-3xl font-black md:text-6xl'> | ||
| {' '} |
Comment on lines
+1
to
+3
| type ButtonInterface = { | ||
| readonly title: string; | ||
| }; |
There was a problem hiding this comment.
déjà déclarée dans un autre fichier de cette PR
Comment on lines
+11
to
+13
| const userLoginRouter = Router(); | ||
|
|
||
| export const cookieRouterGet = Router(); |
Comment on lines
+15
to
+20
| declare module 'Express' { | ||
| // eslint-disable-next-line @typescript-eslint/consistent-type-definitions | ||
| interface Request { | ||
| userId?: number; | ||
| } | ||
| } |
Comment on lines
+4
to
+7
| import loginGuards from './middlewares/login.guards'; | ||
| import loginMiddleware from './middlewares/login.middleware'; | ||
| import userLoginRouter, { cookieRouterGet } from './subrouters/login-router'; | ||
| import userLogout from './subrouters/logout-router'; |
There was a problem hiding this comment.
c'est n'importe quoi le nommage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.