allowing users to see the number of sightings associated with a given… #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naknomum
reviewed
Apr 18, 2025
src/main/webapp/individuals.jsp
Outdated
| @@ -8,8 +8,6 @@ java.net.URL, | |||
| org.datanucleus.ExecutionContext,java.text.SimpleDateFormat, | |||
| org.joda.time.DateTime,org.ecocean.*,org.ecocean.social.*,org.ecocean.servlet.ServletUtilities,java.io.File, java.util.*, org.ecocean.genetics.*,org.ecocean.security.Collaboration, org.ecocean.security.HiddenEncReporter, com.google.gson.Gson, | |||
| org.datanucleus.api.rest.RESTUtils, org.datanucleus.api.jdo.JDOPersistenceManager, java.text.SimpleDateFormat, org.apache.commons.lang3.StringUtils" %> | |||
There was a problem hiding this comment.
these need to be left in now, due to Shepherd and ShepherdProperties now (in main) being moved to their own package.
naknomum
reviewed
Apr 18, 2025
| @@ -1384,6 +1382,50 @@ if (sharky.getNames() != null) { | |||
| } | |||
| %> | |||
|
|
|||
There was a problem hiding this comment.
i have a suggestion to make this much simpler. i am not sure why the code inside this jsp (not your code) is loading getMarkedIndividual() so many times! its pretty bad form.
so i will suggest rather you set an int value at the top (around line 186) e.g. int encCount = 0 ... then the first time myEncs.size() is calculated -- use that value.
then all of this code you added can be reduced to your <div>....</div> code, but use encCount in there.
naknomum
requested changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… individual.
allowing users to see the number of sightings associated with a given individual.
PR fixes #834
Before you Submit!