-
Notifications
You must be signed in to change notification settings - Fork 104
Replace visual breast physics with weighted deformation. #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OnlyJugs
wants to merge
3
commits into
WildfireRomeo:fabric-1.21.11
Choose a base branch
from
OnlyJugs:fabric-1.21.11-experimental
base: fabric-1.21.11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−29
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Wildfire's Female Gender Mod is a female gender mod created for Minecraft. | ||
| * Copyright (C) 2023-present WildfireRomeo | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.wildfire.render; | ||
|
|
||
| import net.fabricmc.api.EnvType; | ||
| import net.fabricmc.api.Environment; | ||
|
|
||
| /** | ||
| * Per-vertex physics deformation parameters for breast rendering. | ||
| * | ||
| * <p>Instead of applying physics offsets as uniform translations (which moves the entire breast | ||
| * including the base that should stay attached to the body), these values are applied per-vertex | ||
| * weighted by the vertex's Y-distance from the attachment edge. This creates a natural bending/stretching | ||
| * effect where the base stays anchored and only the tip moves with the physics.</p> | ||
| * | ||
| * @param offsetX Horizontal sway offset (from {@code BreastPhysics.positionX}) | ||
| * @param offsetY Vertical bounce offset (from {@code BreastPhysics.positionY}) | ||
| * @param velocityY Spring velocity for squash-and-stretch effect (from {@code BreastPhysics.velocity}) | ||
| * @param bounceRotY Y-axis bounce rotation in radians (lateral sway from {@code BreastPhysics.bounceRotation}). | ||
| * Applied per-vertex weighted so the attachment edge stays anchored. | ||
| */ | ||
| @Environment(EnvType.CLIENT) | ||
| public record PhysicsDeformation(float offsetX, float offsetY, float velocityY, float bounceRotY) { | ||
| /** | ||
| * A no-op deformation that applies no physics effects. Used when bounce physics are disabled. | ||
| */ | ||
| public static final PhysicsDeformation NONE = new PhysicsDeformation(0, 0, 0, 0); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why you're creating this again instead of providing the instance the caller already has?