Account for ASCII control character display width - #1021
Open
subotac wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks for the PR. Have you confirmed that the characters render at the same width both with and without less? |
Author
|
Thanks! I have only verified the width calculation with the regression test so far, not the actual rendering both directly and through |
Keep ANSI escapes and line endings intact while converting source control characters to caret notation.
Author
|
Confirmed both paths. The updated output renders non-formatting ASCII controls as caret notation; the issue fixtures contain no raw Unit Separator bytes, and the direct output is byte-for-byte identical after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #569
Testing
AI-assisted tooling was used for test development I reviewed and verified every submitted line and can explain the change.