Skip to content

test: cover PKCE callback token exchange#69

Merged
WilsonLe merged 2 commits into
mainfrom
63-pkce-broken-with-defaultgettoken-callback-endpoint-never-supplies-pluginoptions-pkceenabled
May 7, 2026
Merged

test: cover PKCE callback token exchange#69
WilsonLe merged 2 commits into
mainfrom
63-pkce-broken-with-defaultgettoken-callback-endpoint-never-supplies-pluginoptions-pkceenabled

Conversation

@WilsonLe

@WilsonLe WilsonLe commented May 7, 2026

Copy link
Copy Markdown
Owner

Closes #63

Summary

  • Add mocked provider regression coverage for PKCE callback token exchange.
  • Assert the callback request forwards the authorize-issued pkce_verifier cookie into the default token request as code_verifier.
  • Move agent instruction files from .github/instructions to docs/instructions and keep PKCE callback coverage guidance there.

Credit

Thanks to @arcassia for reporting #63 and opening #64 with the original pkceEnabled / req callback fix.

Testing

  • pnpm install --frozen-lockfile
  • pnpm test
  • pnpm build
  • pnpm exec prettier --check docs/instructions/*.instructions.md test/mocked-provider-integration.spec.ts

@WilsonLe WilsonLe merged commit f60625a into main May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PKCE broken with defaultGetToken - callback endpoint never supplies pluginOptions.pkceEnabled

1 participant