-
Notifications
You must be signed in to change notification settings - Fork 9
Disable artifact upload by default #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5dea2db
to
f9483db
Compare
The errors with missing cache entires we are seeing are caused by the fact that several conditions needs to be met to allow transwer of cache packages accross different runners (see https://github.com/actions/cache?tab=readme-ov-file#cache-version):
I have myself issues to make it working withing this PR #241 |
@@ -369,15 +376,15 @@ jobs: | |||
.github/scripts/toolchain/pack-runtime.sh | |||
|
|||
- name: Upload build folder | |||
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && failure() }} | |||
if: ${{ steps.cache-toolchain.outputs.cache-hit != 'true' && env.UPLOAD_ARTIFACTS == 'true' && failure() }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build folder is uploaded for the reason of debugging when build fails. This should not happen that frequently. If its size is still a problem remove the step entirely as with default false is not usefull at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful when UPLOAD_ARTIFACTS is true and it can be used for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks acceptable when the caching issues will be resolved.
No description provided.