fix: preserve item deletion feedback and clear stale detail state - #243
Merged
stefan-ernst merged 3 commits intoSep 9, 2026
Merged
Conversation
|
This PR has merge conflicts that need to be resolved before it can be merged. Please rebase on the latest |
|
Merge conflicts have been resolved. |
Contributor
|
Hey @Optic00 - thanks! Ready to review from your perspective? |
Optic00
marked this pull request as ready for review
September 9, 2026 09:42
Contributor
Author
|
Yes, ready for review from my side. The remaining diff is limited to clearing stale detail state after deletion and ignoring stale diagram failures. Both targeted browser scenarios pass, and all PR checks are green. The broader test migration stays in draft separately. |
Contributor
|
great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep deleted detail state from leaking into the next item. Only two files remain in the diff. The informational toast, POST reparent request and reparent test selector come unchanged from main.
Reset the shared detail store before navigating away and allow a reused detail component to load the new parent. Ignore diagram failures belonging to an aborted request or a previous item. A 404 for the current item still marks it deleted.
Both targeted Chromium deletion scenarios pass against this branch: opening another board card after deletion, and reparenting without live events. Playwright reports three passes including setup, with no skips or retries. The companion tests are in core-tests draft #1.
The quick suite passes five Go packages and 123 frontend tests. Full browser and PostgreSQL qualification remain incomplete in the separate test migration.