Skip to content

fix: preserve item deletion feedback and clear stale detail state #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-ernst merged 3 commits into from
Sep 9, 2026
Merged

fix: preserve item deletion feedback and clear stale detail state #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06ccab8
fix: preserve item deletion feedback and reparent navigation
Optic00 Sep 7, 2026
f88c730
merge: retain deletion follow-ups on current main
Optic00 Sep 7, 2026
db76fe6
Merge latest main into item deletion feedback fix
Optic00 Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/lib/features/items/ItemDetail.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,10 @@ import NativeSelect from '../../components/NativeSelect.svelte';

function handleDeleteComplete(result) {
showDeletionFeedback();
// Do not let the next detail briefly render the deleted shared-store item.
itemDetailStore.reset();
// Reparent navigation can reuse this component; allow its next item load.
itemDetailStore.loading = false;
const collectionId = $currentRoute.params?.collectionId;
// Navigate based on deletion result
if (result?.mode === 'reparent' && result?.newParentId) {
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/lib/stores/itemDetailStore.svelte.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,9 @@ class ItemDetailStore {
return this.diagrams;
})
.catch((err) => {
if (isAbortError(err)) return this.diagrams;
if (isAbortError(err) || controller.signal.aborted || this.item?.id !== itemId) {
return this.diagrams;
}
if (err?.status === 404) {
this.markDeleted();
return this.diagrams;
Expand Down
Loading