Skip to content

Conversation

@eskay993
Copy link

Added a new verb msls31_x64 which installs both a 32-bit and 64-bit version of the dll as needed, depending on the arch. The existing msls31 verb only installs a 32-bit version, which causes a crash with 64-bit apps using rich text with msftedit and extended Unicode characters.

The official IE8 installer has the needed dlls, so this PR adapts the ie8 verb and strips it down to just handling both versions of msls31.dll.

I created a new verb since msls31 is called by other functions, so did not want to introduce anything unexpected. The version of the dll included with the IE8 installer is slightly newer than the one grabbed by msls31.

Also updated the title of msls31 to make it clear it's 32-bit only.

Thank you.

@austin987
Copy link
Contributor

Thanks for the PR. I think in this case it makes sense to rename the old verb and have the new one be the default. I'd suggest msls_nt4 for the rename.

@eskay993
Copy link
Author

Sorry for the late reply. Sounds good, I'll switch the names round and send an update shortly. Many thanks.

@austin987
Copy link
Contributor

Please fix the shellcheck issues (and preferably, squash the commits).

Something else I realized: existing references to msls31 should be checked/possibly changed to use the nt4 version. I can do that after merging this if you can't.

Also rename old verb to msls31_nt4
@eskay993
Copy link
Author

eskay993 commented Sep 2, 2025

No worries. Tidied up trailing spaces and squashed to one commit.

Checking others that call the old verb is a good shout. One of them is being ie8 itself. From my early testing, after it calls the old verb, it then overwrites msls31.dll with one from the ie8 package anyway. Not sure if this is a redundant call and not needed, or if there is a reason for it.

The other two are riched20 and ie6 which I haven't played around with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants