Fixing compiler warnings. #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socket.c warnings for unused variables, and similar in wizchip_conf.c as well as some int/uint comparisons and one structure init that needed extra elements added.
Static functions cannot be accessed outside the file, so having their prototypes in a .h header file included by other code will cause compiler warnings. I commented out the prototypes in socket.h, and copied them into the socket.c.
Author
|
Once you start using other files, like snmp.c/.h, they include socket.h which creates a few more warnings due to static function prototypes in the header. Since static functions cannot be accessed outside of their file, having the prototype in the header does not work. |
Stub functions have no prototypes, so if that warning is enabled, warnings are generated.
Author
|
// -Wall -Wextra -Wshadow -Wcast-qual -Wmissing-prototypes Not using -Wconversion yet since there are a ton of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into compiler warnings on two different PIC24 compilers (CCS and MPLAB), and fixed them.