Phase 0 bonus - Bug fixes & developer experience - #49
Merged
Conversation
Replace hard-coded margin-left:170px with Bootstrap d-block mx-auto classes so the button centers properly on all viewport sizes.
…oses #24) ProfilesSitemap was querying all profiles including soft-deleted and private ones, and Profile lacked get_absolute_url() which Django's sitemap framework requires. Now only public profiles appear in the sitemap.
Direct links like /faq/#heading-resources now auto-expand the target accordion section and scroll to it. Uses Bootstrap's Collapse API on DOMContentLoaded.
Use coverage run --source=profiles with --fail-under=50 threshold. Remove makemigrations from CI — migrations are now committed to the repo and should not be generated during test runs.
…kend Remove duplicate email block that silently overrode values with empty strings. Add section comments and use console email backend for local development so emails are printed to stdout instead of failing silently.
README now includes venv setup, test instructions, Docker option, and pre-created test accounts. CONTRIBUTING.md was empty — now covers workflow, PR guidelines, and coding style.
Production repo on PythonAnywhere is at ~/winrepo-prod, not ~/winrepo.
HugoFara
marked this pull request as ready for review
April 10, 2026 22:22
Author
|
Done testing and setting up env vars. Ready to add. |
This was referenced Apr 10, 2026
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48.
Bug fixes
margin-left:170pxwith Bootstrap centering classes. Now responsive on all viewports.Profilewas missingget_absolute_url(), which Django's sitemap framework requires. Also filtered out private and soft-deleted profiles from the sitemap./faq/#heading-resourcesnow auto-expand the target accordion section and scroll to it.Developer experience
coveragewith--fail-under=50. Current coverage: 83%. Also removedmakemigrationsfrom CI (migrations are committed since Modernization Phase 0 — Infrastructure & Backend Stabilisation #48)..env.default— Removed duplicate email block that silently overwrote values. Added section comments. Local dev now uses console email backend (emails print to stdout).admin/admin,user/user).Tests
62 tests passing (same count as #48, +1 sitemap smoke test replacing the duplicate count).