DontExtractStandard.xml file creation #2456
Conversation
fix incomplete description of invalid use case description
There was a problem hiding this comment.
@aiolachiara Thank you for working on this!
I agree with the remark @GaryJones left previously and have added a few more nitpick comments inline.
I look forward to seeing the next iteration of the PR!
| my_extract( $var_array, EXTR_OVERWRITE ); | ||
| ]]> | ||
| </code> | ||
| <code title="Invalid: use `extract()` function"> |
There was a problem hiding this comment.
| <code title="Invalid: use `extract()` function"> | |
| <code title="Invalid: Using the `extract()` function."> |
|
@aiolachiara, I was just wondering if you'll have a chance to finish this off in the near future. It would be great if this PR could be included in the next WPCS release. If you haven't got time or lost interest, please let us know and we'll see if we can find someone to take over. Thanks! |
@rodrigoprimo, I'm sorry for forgetting to complete this PR. I made some fixes to the documentation, and I hope to have included all the suggestions received. |
There was a problem hiding this comment.
@aiolachiara Thank you for making those updates! All looking good.
Only thing left is to use proper punctuation for the Valid/Invalid title (i.e. add a . at the end of each sentence + add the missing "the" in the Invalid title), but we can fix that up on merge if needs be. Let me know if you want to fix this up yourself still or if you prefer we fix it up on merge.
I fixed punctuation and misspellings, I hope It is fine now. |
There was a problem hiding this comment.
@aiolachiara Awesome! Thank you for the quick turn-around. All good from me now ✔️
| <?xml version="1.0"?> | ||
| <documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd" | ||
| title="Don't extract" |
There was a problem hiding this comment.
I know that the sniff is called DontExtract, but maybe the title can be Don't use extract()? To be a bit more clear?
Related to #1722