Skip to content

fix: preserve experiment settings when ai is globally disabled #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turtlepod wants to merge 1 commit into from
+38 −1
Closed

fix: preserve experiment settings when ai is globally disabled #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion includes/Settings/Settings_Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,29 @@ private function render_experiments_section(
<li class="ai-experiments__item <?php echo esc_attr( $disabled_class ); ?>">
<div class="ai-experiments__item-header">
<label class="components-toggle-control" for="<?php echo esc_attr( $experiment_option ); ?>">
<?php
// Disabled checkboxes are omitted from POST; hidden fields keep per-feature values when AI is off.
if ( $global_enabled ) {
?>
<input
type="checkbox"
type="hidden"
name="<?php echo esc_attr( $experiment_option ); ?>"
value="0"
/>
<?php
} else {
?>
<input
type="hidden"
name="<?php echo esc_attr( $experiment_option ); ?>"
value="<?php echo $experiment_enabled ? '1' : '0'; ?>"
/>
<?php
}
?>
<input
type="checkbox"
<?php echo $global_enabled ? 'name="' . esc_attr( $experiment_option ) . '"' : ''; ?>
id="<?php echo esc_attr( $experiment_option ); ?>"
value="1"
<?php checked( $experiment_enabled ); ?>
Expand Down
17 changes: 17 additions & 0 deletions tests/e2e/specs/admin/settings.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );
const {
clearConnectors,
disableExperiments,
enableExperiment,
enableExperiments,
visitConnectorsPage,
visitSettingsPage,
Expand Down Expand Up @@ -117,4 +118,20 @@ test.describe( 'Plugin settings', () => {
)
).toHaveCount( 1 );
} );

test( 'Per-experiment settings persist after disabling and re-enabling AI', async ( {
admin,
page,
} ) => {
await enableExperiments( admin, page );
await enableExperiment( admin, page, 'title-generation' );

await disableExperiments( admin, page );
await enableExperiments( admin, page );

await visitSettingsPage( admin );
await expect(
page.locator( '#wpai_feature_title-generation_enabled' )
).toBeChecked();
} );
} );
Loading