Switch to using a Button component instead of ToolbarButton#375
Switch to using a Button component instead of ToolbarButton#375dkotter merged 3 commits intoWordPress:developfrom
Button component instead of ToolbarButton#375Conversation
… the default editing mode
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nurmhm. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #375 +/- ##
==========================================
Coverage 63.81% 63.81%
Complexity 684 684
==========================================
Files 49 49
Lines 3529 3529
==========================================
Hits 2252 2252
Misses 1277 1277
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dkotter I think this one's good to merge for 0.7.0? |
What?
Closes #368
Switch to using a
Buttoncomponent instead of aToolbarButtoncomponent when in normal editing mode (non-template mode)Why?
In normal editing mode, the title input isn't an actual block and thus doesn't support the normal block toolbar. We more or less "fake" that to inject our generate button when Title Generation is turned on. This leads to some weirdness though where the loading state and the active state would both show.
To fix, we now load a normal
Buttoncomponent and only load theToolbarButtoncomponent when in template editing mode (where the title input is a block). Note this does change the design a bit (see screenshots below).How?
Buttoncomponent instead of aToolbarButtoncomponentUse of AI Tools
Use Cursor running GPT-5.3 Codex to investigate options beyond just overriding core CSS. Final testing and adjustments done by me
Testing Instructions
npm i && npm run buildRe-generatebutton showsRe-generatebutton showsScreenshots