Allow bulk enabling/disabling experiments in groups#379
Allow bulk enabling/disabling experiments in groups#379theskinnyghost wants to merge 3 commits intoWordPress:feature/settings-toggle-autosavefrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @raftaar1191. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/settings-toggle-autosave #379 +/- ##
===================================================================
Coverage 62.63% 62.63%
Complexity 680 680
===================================================================
Files 49 49
Lines 3501 3501
===================================================================
Hits 2193 2193
Misses 1308 1308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ideally #376 gets merged in prior to 0.7.0 going out so I think we just hold on this one until that is merged and this can then be rebased off of
Yeah, I think this is key and what I would expect. With the current approach if I have a couple experiments enabled I can't bulk disable them all without flipping the toggle twice.
I think this will be a nicer, not so "in your face" approach. Was trying to find an example in core to provide as inspiration but didn't find anything in a quick search. But a simple links at the bottom of each section that allow you to quickly enable or disable everything in that section makes sense to me. |
|
@theskinnyghost Looks like this got autoclosed when I merged #376 in and I don't see a way for me to reopen. May need to recreate this PR, unless you can reopen it? |



What?
Closes #334
Add controls to bulk enable / disable all features in an experiment group.
Branched off #376 which contains the work of swapping checkboxes with toggles. The issue mentioned using a checkbox but since we've moved away and using toggles now I thought a
ToggleControlwould be more appropriate.Testing Instructions
npm run test:e2e -- --grep "Plugin settings"