-
Notifications
You must be signed in to change notification settings - Fork 88
Add visual-card presentation for featured experiments #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorgefilipecosta
wants to merge
12
commits into
develop
Choose a base branch
from
add/visual-card-experiment-presentation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+262
−15
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6ab2163
Add presentation and image metadata support to Abstract_Feature
jorgefilipecosta b579089
Declare visual-card presentation for Image and Title Generation
jorgefilipecosta 89b56f5
Pass presentation and image metadata to settings client
jorgefilipecosta e4473e1
Add showcase images for visual-card experiments
jorgefilipecosta 9926bcf
Extend FeatureData types and parsing for visual-card presentation
jorgefilipecosta d29ad3e
Add VisualCardToggle component for showcase experiments
jorgefilipecosta 8da6a3d
Wire visual-card features into DataForm fields and form structure
jorgefilipecosta 158bf85
Add showcase card styles for visual-card experiments
jorgefilipecosta 49396f0
Add get_presentation and get_image to Feature interface
jorgefilipecosta 4417535
Fix lint formatting in VisualCardToggle component
jorgefilipecosta 7a4197a
Review fixes: remove redundant Set, escape image URL, validate presen…
jorgefilipecosta c6b19b3
Replace @wordpress/icons import with inline SVG
jorgefilipecosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not reviewed the rest of the PR yet but I don't think we need to introduce a new argument here to control this. The plan is that any non-experimental Feature should be showcased in this new UI and not in the toggle list below. We haven't "promoted" anything to be non-experimental yet (I have a PR that I'll open soon that does that for Image Generation) but the main thing that controls that is the existing
$stabilityargument. Right now that is set toexperimentalfor all existing Features but for "promoted" Features, that will be set tostable. I'd suggest we use that to determine the UIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I've opened #418 which brings Image Generation from an experimental Feature to a stable Feature. It does not touch any of the UI though as I'm leaving that for this PR. So these two PRs will go hand-in-hand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good @dkotter, I will review your PR, and then update this one to use the mechanism we land on yours to specify a feature is stable.