-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[Monorepo] import gutenberg-mobile as a package #18159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4802 commits
Select commit
Hold shift + click to select a range
f10c6f4
Update AztecEditor-iOS to 1.9.0
965447e
Bump version to 1.13.0
719c111
Update bundles
8ab38d5
Remove unused require
fb33f0c
Fix tests
d0cc756
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
8c2c477
Add missing @wordpress/block-directory package in symlinked-packages
08caa7c
Update gutenberg ref
fc8eb7d
Only report selection changes if text view is still first responder.
e71f34a
Don't allow interactions with URL in Aztec text blocks.
ad9edc1
Merge pull request #1372 from wordpress-mobile/release/1.13.0
e74f4cd
Merge pull request #1376 from wordpress-mobile/master
ba7d6f0
Updated gutenberg ref
f84373a
Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…
0ba72e8
Update GB reference.
8b0bb3a
Update GB reference.
88b921c
Pass media filter on media upload
02965cc
Update gutenberg ref
1e0ad56
Use real timers for e2e tests
4dc784e
Update GB reference.
25c4488
Move selection to the start of the URL.
0fec680
Make sure links selection is still possible.
7735be5
Work around for link selection.
e930453
Join two guards.
e309cd8
Update GB reference.
97da943
Use fake timers in unit tests not config
66b4f92
Enable the CSSUnderlinePlugin on Aztec Android
8e187d5
Make sure to handle the new available format `underline`, passed from…
ec4d74c
Update GB ref
2cf5c1b
Update GB reference.
e220399
Merge pull request #1374 from wordpress-mobile/issue/1368_add_link_to…
373afe7
Update package version.
73d7956
Merge branch 'master' into hotfix/1.11.1
36cfcb3
Update GB reference.
6c9af81
Merge branch 'develop' into issue/1373_tap_links_opens_safari
72cbc1e
Merge pull request #1382 from wordpress-mobile/hotfix/1.11.1
0aaeceb
Update GB reference.
97b34f0
Update GB reference.
dd3a6d6
Merge pull request #1377 from wordpress-mobile/issue/1261_add_missing…
091a75e
Merge branch 'develop' into issue/1311_fix_paste_without_formatting
5b48d58
Update GB reference.
f168710
Merge branch 'develop' into issue/562_add_underline
89d265e
Update gutenberg ref
44b5f6b
Update gutenberg ref
8500674
Update gutenberg ref
03cc901
Update gutenberg ref
47ed605
Update gutenberg ref
bfe9d35
Update GB reference.
042ee2b
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
79009b1
Add comment explaining why we need to call jest.runAllTicks();
82ce8df
Fix lint issue on rmobile/master on gutenberg repo (#1388)
257733d
Update GB reference.
69c339d
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
d597760
Merge branch 'develop' into issue/1311_fix_paste_without_formatting
b651fbe
Update gutenberg ref
640455e
Merge pull request #1360 from wordpress-mobile/issue/1311_fix_paste_w…
b7d3cfd
Update GB reference.
3695a12
Merge branch 'develop' into issue/562_add_underline
0a29522
Update gutenberg ref
e7e7b7b
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
4b6e763
Update gutenberg ref
169c04e
Update gutenberg ref
6eb780d
Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…
155d694
Gitmodules update
b390e1d
Update gutenberg ref
1e3e16a
Update GB reference.
c364ab4
Merge pull request #1361 from wordpress-mobile/feature/move-media-upl…
545ab3e
Update GB reference.
20a565c
Increase the number of workers so tests don't get queued when calling…
3b5577f
Reenable disabled e2e tests
6c75768
Reenable disabled e2e tests
8c9f4cb
Update gutenberg ref
81168f5
Update gutenberg ref
fb6db57
Disable warning notices
561f27e
Disable warning notices, fix lint
078e62d
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
39856db
Update GB reference.
56f8d09
Merge branch 'develop' into issue/1373_tap_links_opens_safari
0081ee8
Update gutenberg ref
71815cb
Update GB reference.
be87adf
Revert max workers to 3 and increase timeout in tests for now
b55f55d
Update gutenberg ref
36fb499
Merge pull request #1366 from wordpress-mobile/update/fix-store-crash
9aaa7d6
Update GB reference.
57459f9
Add isAppender functionality to MediaPlaceholder (#1327)
945626e
Only apply selection fix on iOS 13.0.0
731b965
Merge branch 'develop' into issue/1373_tap_links_opens_safari
fbc1ad1
Update GB reference.
2b1673b
Feat: Cross platform InspectorControls (#1341)
e0c41aa
Update release notes.
040d5ad
Update GB reference.
662a3f7
iOS bridge updated with media type
36c1153
Update GB reference.
16283de
Update GB reference.
c523a94
Update gutenberg ref
e0e76bd
Update GB reference.
1ddbc6f
Merge pull request #1393 from wordpress-mobile/master
44544a9
Merge branch 'develop' into issue/1373_tap_links_opens_safari
3f07a87
Update gutenberg ref
638c72e
Merge pull request #1375 from wordpress-mobile/issue/1373_tap_links_o…
58ea6d3
Update gutenberg ref
d418604
Mock media type for media upload
c0a9832
Update gutenberg ref
89f4ba2
Return media type in Android's bridge
9f01b36
Refactor: BottomSheet controls (#1380)
f942586
Fix when multiple media selection adds only one image or video block …
b8e8fe1
Feat: support of multiple selection in media upload (#1331)
4932f88
Update gutenberg ref
882b290
Merge branch 'develop' into issue/1337-link-to-open-new-tab
39bc443
Adding Link Target entry to release notes 1.15.0
1100c3d
Update Gutenberg
baf32b3
Update gutenberg ref to master
717c69d
Merge remote-tracking branch 'origin/develop' into issue/darkmode-too…
488af84
Merge pull request #1357 from wordpress-mobile/issue/darkmode-toolbar…
c5e7dcf
Update gutenberg ref to master
e13d739
Merge remote-tracking branch 'origin/develop' into issue/1337-link-to…
e3d7753
Merge pull request #1394 from wordpress-mobile/issue/1337-link-to-ope…
054a92b
Feat: Ungrouping (#1381)
70061b2
Add FloatingToolbar component (#1362)
a154f5c
Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…
9e7b2e8
Update to fork
6149454
Merge branch 'develop' into issue/562_add_underline
84db3e6
Update Aztec to version 1.10.1
00b7b05
Merge pull request #1370 from wordpress-mobile/issue/562_add_underline
d2ab272
Release/1.14.0 (#1392)
e3fc356
Merge branch 'develop' into master-v1.14.0-to-develop
465cdbf
Revert gb ref to latest from develop
a4136a3
Media & Text - Android: Fix return media type
33f3f22
Update gutenberg ref
edfae08
Add upload media to button listener interface in glue code
56ffdcb
Add "media" MediaType
796d3ca
Detect "media" MediaType from filter
fc85748
Invoke button listener method for "media" MediaType
4097c57
Use MediaType static import consistently
58a7345
[RNAztec iOS]: Improve sync of placeholder attributes and typing attr…
8a3aa11
Update gutenberg ref
fc5ca0b
Update release notes
e6dc2db
Update gutenberg ref
e0fbf04
Feat: Navigation Upward in InnerBlocks (#1371)
fff1857
Update gutenberg ref
db457da
Merge remote-tracking branch 'origin/develop' into master-v1.14.0-to-…
6ceeab3
Update JS Bundles
0d13e85
Merge pull request #1410 from wordpress-mobile/master-v1.14.0-to-develop
bf332c6
Merge remote-tracking branch 'origin/develop' into issue/1391-ios-dar…
b5c2b1c
Update gutenberg ref
a2623b9
Merge pull request #1415 from wordpress-mobile/issue/1391-ios-dark-mo…
7009c25
Update Gutenberg
370ea44
Merge branch 'develop' into media-text-stacking
8b40aa7
Update Gutenberg
4c435bc
Update to iOS11 and Swift 5.
f0012fe
Remove check for iOS 11
164281c
Fix SafeArea (#1425)
e0496dc
Update Gutenberg
6acee9d
Merge branch 'develop' into media-text-stacking
a461fc8
Merge pull request #1400 from wordpress-mobile/media-text-stacking
6523e9d
Merge pull request #1426 from wordpress-mobile/issue/update_to_iOS11_…
db7e303
Update Gutenberg
16d03ab
Merge branch 'develop' into feature/media-text-improvements
70b4f7c
Update gutenberg submodule
e9de861
Update gutenberg submodule
c7e573a
Updated bundles
de6141a
Merge pull request #1378 from wordpress-mobile/feature/media-text-imp…
1ec600a
Merge branch 'develop' into try/fix-media-text-device-picker-android
2fb8c33
Update gutenberg reference
3bfb7aa
Call media library method for media mediatype
be4a276
Update deployment target for RNTAztecView to iOS 11
b2a5295
Fix header search path for libmxl2
377f4bb
Bump swift_version to 5.0 on RNTAztecView podspec
9c1cfb8
Merge pull request #1434 from wordpress-mobile/rntaztec-ios11
ad425a3
Import new location for base styles
65d8efa
Update gutenberg
5d854d8
Update gutenberg
045af30
Update bundles
2c16ab5
Update release notes
24b7f64
Don't display UngroupingButton for Media&Text block (#1420)
e228e17
Update gutenberg
1cbdf92
Update gutenberg
8587620
Update gutenberg
6354239
Merge branch 'develop' into issue/fix-scrollViewRef-crash
f5a2739
Merge pull request #1438 from wordpress-mobile/issue/fix-scrollViewRe…
fe20493
Merge branch 'develop' into try/fix-media-text-device-picker-android
50ed338
Merge pull request #1412 from wordpress-mobile/try/fix-media-text-dev…
9db0e46
Merge pull request #1435 from wordpress-mobile/add/package-base-styles
6de84cb
Update Gutenberg
1c8c2d8
Merge branch 'develop' into fix/button-active
18876f1
Merge pull request #1440 from wordpress-mobile/fix/button-active
d7cf6f9
Update Gutenberg
8b07ba8
Merge branch 'develop' into enable-media-text
658eeba
Updated bundles
57c630f
Merge pull request #1439 from wordpress-mobile/enable-media-text
df0f112
Update Gutenberg
0ef429f
Add Media & Text block to initial HTML
895edaa
Update Gutenberg
3e9536a
Merge pull request #1443 from wordpress-mobile/issue/1411-media-text-…
fb25c0c
Add 'packages/react-native-editor/' from commit '3e9536a973321c9c7e31…
97511b5
move packages to its directories
aa8765a
split to packages
cd1ebda
add packages to package.json
1117263
fix tests
2f55a45
fix tests and lint
b209fb7
fix image test
f1d2457
fix import of aztec
1157eb0
update package-lock.json
a452c41
remove makepot
00d5555
working e2e ios temp
812acff
add project root
f226470
move podspecs and fix lint issues in aztec
37a3275
move proptyopes
80435de
remove class properties from aztec
6cfabd1
experimental - move podspec to root lvl
2456541
fix podspec
10232f1
fix paths
cdadddd
add bundle
d5c67a1
add flow strip types plugin
cd1ca78
support wp android script
5678175
move jitpack.yml
651cb7d
Merge branch 'master' into rnmobile/monorepo
0e0a472
add base styles
619bb6f
temporary fix for build
11510b8
exclude device tests from unit tests
9d7bf89
remove unused colors and fix lint
dedfbb8
exclude native test from unit tests
3961824
revert colors
969597f
try ignore react-native-editor in build script
0deca2e
tmp - fix lint-types
9677a04
fix script to remove globals from r-n types
4710287
remove fox types from postinstall
6309a8e
change fix-types script
695bb7a
fix webpack config
3fa5a7a
trigger CI
1ed285f
merge with master
f16d98c
use patch package to fix types instead of fix-types.sh
50ec247
add prepare script
8228b4b
change prepare to postinstall
faee6b3
fix aztec-example package.json
9007a2a
fix package-lock.json
016c8c2
update docs
689f893
fix package-lock.json
7e036cc
move dev dependencies to the root
83fccc9
move node-sass to devdeps
3ecaf32
change jitpack gradle script
542a56d
change from yarn to npm in jitpack
1e79b47
remove allow failures for mobile tests
046fd8b
fix buildJSBundle script
2b0e47b
move native to command
2e91b74
try w/o prefix command
f971f81
trigger build
c22ea2e
put back DependencyGraph patch
e97fdb1
Merge with master
81843ea
update package.json
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -212,6 +212,3 @@ jobs: | |
| local_dir: playground/dist | ||
| on: | ||
| branch: master | ||
|
|
||
| allow_failures: | ||
| - name: JavaScript native mobile tests | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package = JSON.parse(File.read(File.join(__dir__, 'packages', 'react-native-editor', 'package.json'))) | ||
| # Use the same RN version that the JS tools use | ||
| react_native_version = package['dependencies']['react-native'] | ||
| # Extract the tagged version if package.json points to a tag | ||
| react_native_version = react_native_version.split("#v").last if react_native_version.include? "#v" | ||
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = 'Gutenberg' | ||
| s.version = package['version'] | ||
| s.summary = 'Printing since 1440' | ||
| s.homepage = 'https://github.com/WordPress/gutenberg/' | ||
| s.license = package['license'] | ||
| s.authors = 'Automattic' | ||
| s.platform = :ios, '11.0' | ||
| s.source = { :git => 'https://github.com/WordPress/gutenberg.git' } | ||
| s.source_files = 'packages/react-native-bridge/ios/*.{h,m,swift}' | ||
| s.requires_arc = true | ||
| s.preserve_paths = 'packages/react-native-editor/bundle/ios/*' | ||
| s.swift_version = '5.0' | ||
|
|
||
| s.dependency 'React', react_native_version | ||
| s.dependency 'React-RCTImage', react_native_version | ||
|
|
||
| s.dependency 'WordPress-Aztec-iOS' | ||
| s.dependency 'RNTAztecView' | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| require 'json' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, would be awesome if we didn't add new files at the root |
||
|
|
||
| package = JSON.parse(File.read(File.join(__dir__, 'packages', 'react-native-editor', 'package.json'))) | ||
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = 'RNTAztecView' | ||
| s.version = package['version'] | ||
| s.summary = 'Aztec editor for React Native' | ||
| s.license = package['license'] | ||
| s.homepage = 'https://github.com/WordPress/gutenberg/' | ||
| s.authors = 'Automattic' | ||
| s.source = { :git => 'https://github.com/WordPress/gutenberg.git' } | ||
| s.source_files = 'packages/react-native-aztec/ios/RNTAztecView/*.{h,m,swift}' | ||
| s.public_header_files = 'packages/react-native-aztec/ios/RNTAztecView/*.h' | ||
| s.requires_arc = true | ||
| s.platforms = { :ios => "11.0" } | ||
| s.swift_version = '5.0' | ||
| s.xcconfig = {'OTHER_LDFLAGS' => '-lxml2', | ||
| 'HEADER_SEARCH_PATHS' => '/usr/include/libxml2'} | ||
| s.dependency 'React-Core' | ||
| s.dependency 'WordPress-Aztec-iOS' | ||
|
|
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| const config = process.env.MOBILE ? require( './packages/react-native-editor/babel.config' ) : { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to double-check how Babel caching works with envs. |
||
| presets: [ '@wordpress/babel-preset-default' ], | ||
| plugins: [ 'babel-plugin-inline-json-import', '@babel/plugin-transform-flow-strip-types' ], | ||
| }; | ||
| module.exports = function( api ) { | ||
| api.cache( true ); | ||
|
|
||
| return { | ||
| presets: [ '@wordpress/babel-preset-default' ], | ||
| plugins: [ 'babel-plugin-inline-json-import' ], | ||
| }; | ||
| return config; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| before_install: | ||
| - yes | $ANDROID_HOME/tools/bin/sdkmanager "platforms;android-27" | ||
| - yes | $ANDROID_HOME/tools/bin/sdkmanager "build-tools;27.0.3" | ||
| install: | ||
| - export TMPDIR=`dirname $(mktemp)` | ||
| - echo "Changing into the android folder of the Bridge module" | ||
| - pushd packages/react-native-bridge/android && ./gradlew --stacktrace clean -Pgroup=com.github.wordpress.gutenberg -Pversion=$VERSION install && popd | ||
| - pushd packages/react-native-aztec/android && ./gradlew --stacktrace clean -Pgroup=com.github.wordpress.gutenberg -Pversion=$VERSION install && popd | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this file to
@wordpress/react-native-bridge, or could we even?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to move it to
packages/react-native-bridgebut couldn't make it works withWordpress-iOS. I don't know why but cocoapods can not readpackage.jsonwith that configuration.