Skip to content

[RNMobile] Ensure dictating text doesn't cause cursor to be offset on iOS #51528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2023
Merged

[RNMobile] Ensure dictating text doesn't cause cursor to be offset on iOS #51528

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0df56
fix: Ensure dictating doesn't offset cursor
SiobhyB Jun 15, 2023
35316ba
Merge branch 'trunk' into rnmobile/fix/dictation-cursor-position
SiobhyB Jun 15, 2023
88b18c4
docs: Reword comment for correctness/readability
SiobhyB Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,10 @@ class RCTAztecView: Aztec.TextView {

// Replace occurrences of the obj symbol ("\u{FFFC}")
textView.text = textView.text?.replacingOccurrences(of: "\u{FFFC}", with: "")

if let newPosition = textView.position(from: textView.beginningOfDocument, offset: originalPosition) {

// Detect if cursor is off-by-one and correct, if so
let newPositionOffset = originalPosition > 0 ? originalPosition - 1 : originalPosition
if let newPosition = textView.position(from: textView.beginningOfDocument, offset: newPositionOffset) {
// Move the cursor to the correct, new position following dictation
textView.selectedTextRange = textView.textRange(from: newPosition, to: newPosition)
}
Expand Down