Command Palette: Change link destination of "Customize CSS" for non-block themes#65155
Closed
Command Palette: Change link destination of "Customize CSS" for non-block themes#65155
Conversation
t-hamano
added
[Type] Bug
t-hamano
changed the title
|
Size Change: +55 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Why is this step required for the "customize CSS" command to be registered? (especially if it goes to the customizer) |
Contributor
Author
|
Thanks for the review!
In the case of a theme that does not have a theme.json, Therefore, in order to reproduce the problem, we will need to explicitly add theme.json. In themes that do not have a theme.json, I assume that it is the expected specification that |
Contributor
That seems correct but I think check shouldn't apply to classic themes as they don't care about whether there's a global styles id, the customizer CSS panel is always there no? |
Contributor
Author
As far as I know, there is no way to disable the Customizer CSS section. Even in the core, it doesn't seem to check whether Customizer CSS is present: However, there is a |
Contributor
Author
|
Closing this in favor of #77685 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64932
What?
This PR changes the link destination of the "Customize" command to the Customizer for non-block themes.
Why?
The additional CSS in the site editor is part of the global styles. Currently, non-block themes do not have access to this additional CSS.
How?
I considered disabling the command itself, but decided to link it to the Customizer.
The Customizer can automatically open any section via the
autofocusURL parameter.Testing Instructions
Please update your local environment to the nightly version beforehand, because there was a reported issue with
autofocusnot working, which was recently fixed: https://core.trac.wordpress.org/ticket/61561Screenshots or screencast
37a30f870be3a13d4d459de9a152c649.mp4