-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Routing Boot Package: Remove margin and border-radius from layout components #75053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
this only solves the issue partially for me. I think the "extensible site editor"'s sidebar color should also adapt to the profile. and I'm on the fence about removing the padding on the fonts screen, it's good that it's closer to site editor design, kind of bridges both. |
|
Yes :) |
I think we are going to need to work on a Core patch to expose these colors cleanly for Gutenberg. Let me check the thing, and I will ping you there to see if we can make it. |
|
Added upstream: #64571 |
| color: var(--wpds-color-fg-content-neutral, #1e1e1e); | ||
| isolation: isolate; | ||
| background: var(--wpds-color-bg-surface-neutral-weak, #f0f0f0); | ||
| background: var(--wp-admin-color-menu-background, #1d2327); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also switched to #1d2327 as this is the default base color for the Default color scheme. But I can revert back to the #f0f0f0 fallback

What?
Continues #75036
Why?
@youknowriad commented that when adding Styles in profile, the background was popping for the new layout components
How?
Instead of removing the background, which may make sense in the future with a future admin redesign, simply fully expanding the margins to cover the whole scene and removing the rounded corners fixes the thing while maintaining all backgrounds.
Testing Instructions
Screenshots or screencast