Block visibility: deselect hidden block when list view is not open#76300
Open
Block visibility: deselect hidden block when list view is not open#76300
Conversation
github-actions
Bot
added
[Package] Editor
6 tasks
|
Size Change: +134 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
fix/block-visibility-hide-on-device-deselect
branch
from
c383e86 to
c910831
Compare
ramonjd
added
[Type] Enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an editor UX edge case where switching viewport preview can leave a now-hidden block selected (when List View is closed). It centralizes the “effective viewport” resolution logic and adds unit tests to cover both viewport resolution and the preview dropdown’s deselection behavior.
Changes:
- Add
resolveCurrentViewporthelper for consistent viewport resolution (based on device preview + breakpoint fallbacks). - Clear selected block on viewport switch when List View is closed and the selected block becomes hidden in the target viewport.
- Add unit tests for
resolveCurrentViewportand for preview dropdown deselection behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/editor/src/components/preview-dropdown/index.js | Adds deselection logic on viewport switch (conditional on List View state + block hidden status). |
| packages/editor/src/components/preview-dropdown/test/index.js | Adds unit coverage for deselection vs. List View open/closed behavior. |
| packages/block-editor/src/private-apis.js | Exposes resolveCurrentViewport via block-editor private APIs. |
| packages/block-editor/src/components/block-visibility/use-block-visibility.js | Refactors viewport resolution to use shared resolveCurrentViewport. |
| packages/block-editor/src/components/block-visibility/resolve-current-viewport.js | Introduces shared viewport resolution helper. |
| packages/block-editor/src/components/block-visibility/test/resolve-current-viewport.js | Adds unit coverage for viewport resolution helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…wport - Introduced pageUtils to facilitate key presses in the block hiding test. - Added functionality to open List View before switching to mobile preview to maintain block selection when hidden. - Included a comment referencing the related GitHub issue for clarity.
ramonjd
commented
Apr 16, 2026
| return BLOCK_VISIBILITY_VIEWPORTS.tablet.key; | ||
| } | ||
|
|
||
| return BLOCK_VISIBILITY_VIEWPORTS.desktop.key; |
Member
Author
There was a problem hiding this comment.
While testing this I found a couple of instances of BLOCK_VISIBILITY_VIEWPORTS.desktop.value (value was the old property)
Fix:
ramonjd
changed the title
|
Flaky tests detected in 49d856a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24494411719
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Testing something out for #76275
This PR:
resolveCurrentViewport.Test Steps
Before
Kapture.2026-04-16.at.15.07.38.mp4
After
Kapture.2026-04-16.at.15.06.12.mp4