DependencyExtractionWebpackPlugin: use compilers webpack instance for filesystem cache compatibility in pnpm monorepos.#77284
DependencyExtractionWebpackPlugin: use compilers webpack instance for filesystem cache compatibility in pnpm monorepos.#77284kalessil wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kalessil! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kalessil. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ObliviousHarmony
left a comment
There was a problem hiding this comment.
Thanks @kalessil,
This is a great start! As per Webpack's own plugin example, could we remove require( 'webpack' ) entirely in favor of using compiler.webpack?
What?
Use the webpack instance available in the compiler instance.
Why?
In pnpm monorepos, peer dependencies can result in packages using the same Webpack version but with different versions of their dependencies. During the build process, this may lead to multiple Webpack instances, which can cause serialization warnings and cache misses when using the Webpack filesystem cache.
How?
Use the webpack instance available in the compiler instance.
Testing Instructions
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a
Use of AI Tools
Claude investigated cache misses and confirmed the issue was resolved following the changes.