Tabs: Lock top-level structure and disable visibility controls#77370
Merged
Tabs: Lock top-level structure and disable visibility controls#77370
Conversation
|
Size Change: +22 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
Prevent users from removing or reordering the tabs menu and panels by locking the parent Tabs template, and hide the visibility panel on tab blocks where per-block hiding is not meaningful. Inner menu items remain editable so tabs can still be added or rearranged.
t-hamano
force-pushed
the
tabs-remove-unnecessary-features
branch
from
e3475c8 to
96c2efe
Compare
t-hamano
added
[Type] Bug
t-hamano
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 058867b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24494806417
|
mikachan
approved these changes
Apr 15, 2026
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This tests well for me and the changes look good, thank you! It makes sense to do this for the top-level Tabs Menu and Tab Panel blocks.
Not a blocker, but should we also remove the lock attributes from the TABS_TEMPLATE in tabs/edit.js?
The parent `useInnerBlocksProps` already sets `templateLock: 'all'`,
which cascades to descendants and prevents removal/insertion/move.
The per-child `lock: { remove: true }` entries were therefore no-ops.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
Nice catch! Removed in 058867b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes unnecessary block-editor features from the Tabs block and its inner blocks:
Why?
The Tabs block only works when its fixed structure — a single Tabs Menu paired with a Tab Panel — is preserved. Allowing the menu or panel to be deleted, duplicated, or hidden via the visibility control produces broken semantics.
How?
Testing Instructions
Screenshots or screencast
Use of AI Tools
Claude Code was used to assist with code edits and to draft this description. All changes were reviewed by the author.