Ensure Post Template fallback styles don't apply when minimumColumnWidth is defined#77411
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +183 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in ae1d91b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24496639080
|
andrewserong
left a comment
There was a problem hiding this comment.
with this PR if we want to have a non-responsive grid we have to set minimumColumnWidth to 0px explicitly.
I actually really like the approach here, and to me it didn't feel like an issue that folks would need to manually set the minimum size to zero since we only have two controls in the layout UI, so interacting with it (for me at least) felt pretty natural:
2026-04-17.16.00.36.mp4
In the above video, ignore the placeholders looking weird at that size, I believe it's to do with this min-height rule on the featured image block's placeholder and unrelated to this PR:
This LGTM, but since it's an opinionated change, do feel free to get a second opinion!
Thanks! I'm OK with merging as is because it's a small change, with lower impact than the other PR. We can always revisit if we find it doesn't work well enough. |
What?
Fixes #34145.
Alternative to #76714 by following Andy's suggestion to simplify the change.
Testing steps are the same as #76714, except that whereas in that PR the fallback should have been removed if only columnCount is defined for new blocks, with this PR if we want to have a non-responsive grid we have to set minimumColumnWidth to 0px explicitly.