Notes: Extract floating notes state into a dedicated store#77424
Merged
Notes: Extract floating notes state into a dedicated store#77424
Conversation
Extracts the mutable floating-board state (block refs, floating refs, thread heights) out of React hooks and into a plain JS store (`board-store.js`) consumed via `useSyncExternalStore`.
Mamaduka
added
[Type] Performance
|
Size Change: +47 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in de5e15d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24507973349
|
t-hamano
approved these changes
Apr 16, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This is a great refactoring, and I learned today that useSyncExternalStore is the optimal choice 😄
Member
Author
It seems the right choice for this type of custom store, plus we're subscribing to extrnal API, so yes. |
ciampo
pushed a commit
that referenced
this pull request
Apr 16, 2026
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #77414.
Extract the floating notes board state into a dedicated store and remove the manual
reflowCommentsreflow mechanism.Why?
blockRefs,heights) used ReactuseState, causing full re-renders and synchronousgetBoundingClientRectreads inuseEffect. Rapid state updates (typing, resizing, CRUD) across N threads resulted in redundant recalculations on each render cycle.reflowComments(auseReducer-basedDate.now()counter) was used in about 15 places across 6 files to trigger layout recalculation after comment CRUD and textarea resizing. This approach was fragile and triggered more times than needed. Now it's redundant, theResizeObservermonitors panel heights.How?
Board store: A plain JS store (compatible with
useSyncExternalStore) that holdsblockRefs,floatingRefs, andheightsoutside React state. A singleResizeObserverwatches all floating panel elements and emits only when heights actually change.getBlockRects()batches allgetBoundingClientRectreads in one pass.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before - every keystroke triggers reflow
CleanShot.2026-04-16.at.14.59.08.mp4
After - only actual height changes trigger reflow
CleanShot.2026-04-16.at.14.58.30.mp4
Use of AI Tools
Used Claude to brainstorm my ideas, tested and reviewed personally.