Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
commented
Apr 16, 2026
Comment on lines
-6
to
+10
| "rootDir": "bin", | ||
| "rootDir": ".", | ||
| "noEmit": true, | ||
| "allowImportingTsExtensions": true | ||
| }, | ||
| "include": [ "bin" ], | ||
| "include": [ "bin", "terrazzo.config.ts" ], |
Member
Author
There was a problem hiding this comment.
Changes needed because the new bin script references a file in the root package directory, and TypeScript complains about referencing files outside rootDir.
aduth
commented
Apr 16, 2026
| if ( shouldInline ) { | ||
| // Track this token for inlining | ||
| inlineMap[ id ] = []; | ||
| inlineMap[ id ] ??= []; |
Member
Author
There was a problem hiding this comment.
This isn't strictly needed, but was something that started erroring in the default behavior before adding alphabetize: false. The previous logic relies on primitives being defined before any alias references, which is only true if we disable alphabetization and maintain this convention in the source token files. This change makes it a bit more flexible.
aduth
commented
Apr 16, 2026
Comment on lines
+307
to
309
| export default defineConfig( config, { | ||
| cwd: new URL( './', import.meta.url ), | ||
| } ); |
Member
Author
There was a problem hiding this comment.
I didn't see this mentioned in the migration guide or package release notes, but the code itself errors if cwd is not specified.
aduth
commented
Apr 16, 2026
Member
Author
There was a problem hiding this comment.
This looks like a lot of changes, but it's basically just shifting the description comment from end-of-line to preceding-line.
aduth
added
[Type] Task
Otherwise "not all code paths return a value" TypeScript error. The function types specify `undefined` as a return type, but not `void`.
aduth
commented
Apr 16, 2026
Comment on lines
+67
to
+68
|
|
||
| return undefined; |
Member
Author
There was a problem hiding this comment.
This is needed because the function return types allow undefined but not void. Apparently in my fix proposal I originally included it but later reverted it. I'm not sure why I reverted it 😅
|
Size Change: -36 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 638444a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24566013034
|
mirka
approved these changes
Apr 17, 2026
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Thanks for the thorough contextual comments! Looks good to go 🚀
Comment on lines
+49
to
+51
| `Built ${ outputFiles.length } files to ${ relative( | ||
| resolve( configDir, '../..' ), | ||
| outDir |
Member
There was a problem hiding this comment.
Nit: If anyone moves the script, the printed path will silently go wrong. Could compute relative to process.cwd() instead, or just drop it.
Member
Author
There was a problem hiding this comment.
Good point, I don't think this output is particularly necessary so let's just drop it.
ciampo
added a commit
that referenced
this pull request
Apr 21, 2026
* Theme: Update Terrazzo packages to 2.0 * Use exported members from Node packages * Return explicit undefined in transform function Otherwise "not all code paths return a value" TypeScript error. The function types specify `undefined` as a return type, but not `void`. * Remove build logging from design tokens script Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
maxschmeling
added
the
[Type] Code Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #76630
Updates Terrazzo dependencies used in
@wordpress/themefrom 0.x to 2.0.Related migration guide: https://terrazzo.app/docs/guides/migrating-v2/
Why?
General maintenance to reduce drift and take advantage of features and bug fixes.
Specifically, this includes at least one bug fix we previously had to work-around in plugin typings (terrazzoapp/terrazzo#632).
How?
Some issues / behavior changes to note:
@terrazzo/clinow includes Vite 8 as a dependency, which has a huge dependency chain. To avoid this, I opted to remove this dependency and write a thin wrapper script instead. Since we used very few features of the CLI, this seems like a simpler option (see also removed net negative lines of code on the pull request, largely from removed dependencies).Testing Instructions
Ensure that the build behavior works without errors and produces identical output (i.e. no changes on working branch after run):
Use of AI Tools
Cursor + Claude Opus 4.6 & 4.7 for both research and implementation. Several rounds of manual revisions and post-processing.