Gallery: default lightbox nav to Both and add icon-only focus labels#77686
Open
vishnupprajapat wants to merge 1 commit intoWordPress:trunkfrom
Open
Gallery: default lightbox nav to Both and add icon-only focus labels#77686vishnupprajapat wants to merge 1 commit intoWordPress:trunkfrom
vishnupprajapat wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #77545
This PR updates Gallery lightbox navigation defaults and improves discoverability for icon-only controls.
Why?
In lightbox, icon-only navigation can make control intent less obvious, especially for keyboard users. The issue discussion converged on two improvements:
Bothfor navigation buttons.How?
navigationButtonTypedefault fromicontoboth.bothas baseline.bothfor consistency.:hover(hover-capable devices):focus-visible(keyboard focus)Testing Instructions
npm run wp-env start.Icon.Testing Instructions for Keyboard
Tabto move focus to lightbox controls.Enter/Spaceto trigger control actions.Escto close lightbox.Screenshots or screencast
Use of AI Tools
I used GitHub Copilot (GPT-5.3-Codex) to assist with drafting code changes. I reviewed, validated, and take responsibility for all final changes.