Open
Conversation
github-actions
Bot
added
[Package] Components
mirka
changed the title
|
Size Change: +19 B (0%) Total Size: 7.77 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Apr 28, 2026
| display: inline-block; | ||
| width: 100%; | ||
| min-width: 188px; | ||
| isolation: isolate; |
Contributor
There was a problem hiding this comment.
Should we add a CHANGELOG entry every time we add isolation, like we already did in #77619 ? For this and all PRs doing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Localizes the
CircularOptionPickerz-index values that were previously defined in the sharedz-index()helper.Why?
These stacking values only describe layering within the
CircularOptionPickercomponent, so keeping them in the local component styles makes the shared z-index map smaller and easier to reserve for cross-component stacking concerns.How?
CircularOptionPickerentries frompackages/base-styles/_z-index.scss.isolation: isolateto the component root.z-index()calls with local z-index values inpackages/components/src/circular-option-picker/style.scss.Testing Instructions
npm run lint:css -- packages/base-styles/_z-index.scss packages/components/src/circular-option-picker/style.scss.CircularOptionPicker.Screenshots