Site Editor: Remove local z-index helper entries#77808
Open
Conversation
github-actions
Bot
added
[Package] Edit Site
mirka
commented
Apr 29, 2026
Comment on lines
-35
to
-39
| .edit-site-page-templates { | ||
| .dataviews-pagination { | ||
| z-index: z-index(".edit-site-templates__dataviews-list-pagination"); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
No longer needed, because the parent context .dataviews-footer now sets the z-index 2 (which was added a couple months after this .edit-site-page-templates override was added).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -33 B (0%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 5a8c700. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25122981901
|
ciampo
reviewed
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Looks like a new package release happened after opening this PR — we'll need to rebase/merge trunk and create a new CHANGELOG entry in the Unreleased section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes two Site Editor entries from the shared
z-index()helper.Why?
These z-index values do not need to be coordinated from the shared base styles map. The templates pagination override is now redundant because DataViews already applies the same stacking value to the footer, and the sidebar navigation title icon value is local to that component.
How?
Removes the obsolete templates pagination z-index override and inlines the sidebar navigation title icon z-index in
packages/edit-site/src/components/sidebar-navigation-screen/style.scss.Testing Instructions
npm start./wp-admin/site-editor.php.Screenshots or screencast