Notes: Keep tall floating threads scrollable on short content#77821
Open
Notes: Keep tall floating threads scrollable on short content#77821
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +172 B (0%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
Mamaduka
commented
Apr 30, 2026
| }; | ||
|
|
||
| const handleNoteSelect = () => { | ||
| const onSelectNote = () => { |
Member
Author
There was a problem hiding this comment.
A single method to handle selection for the thread body or show more reply clicks.
| }; | ||
|
|
||
| const unselectNote = () => { | ||
| const onDeselectNote = () => { |
Member
Author
There was a problem hiding this comment.
Nit: Trying to match naming patterns.
Comment on lines
+118
to
+122
| if ( adjacentThread.blockClientId ) { | ||
| toggleBlockSpotlight( adjacentThread.blockClientId, true ); | ||
| // Pass `null` as the second parameter to prevent focusing the block. | ||
| selectBlock( adjacentThread.blockClientId, null ); | ||
| } |
Member
Author
There was a problem hiding this comment.
Not fully related to this issue. Canvas syncing was missing, causing stale block selection/spotlight. This matches keyboard nav behavior.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
adamsilverstein,
jameskoster,
jeffpaul and
t-hamano
|
Flaky tests detected in c728789. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25150491955
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A minor follow-up to #77433.
PR adds a cap to the floating thread height (using dynamic viewport height), allowing replies and the form to be reachable. It seems to be a common approach in other apps, and it makes sense to set a limit so the thread height doesn't exceed the viewport height.
The new
scrollNoteThreadIntoViewshould account for potential recalculations after the thread is expanded.Why?
Previously, this was handled via the canvas max-height hack, which was removed in #77433.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-04-30.at.10.17.32.mp4
Use of AI Tools
Claude for initial review and researching common patterns in other apps.