Experiment: Add first e2e tests for Taxonomies#77828
Open
ntsekouras wants to merge 2 commits intotrunkfrom
Open
Experiment: Add first e2e tests for Taxonomies#77828ntsekouras wants to merge 2 commits intotrunkfrom
ntsekouras wants to merge 2 commits intotrunkfrom
Conversation
ntsekouras
added
[Type] Experimental
|
Size Change: 0 B Total Size: 7.82 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6aa7bc7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25156523057
|
tyxla
approved these changes
Apr 30, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍
Just added a couple of non-blocking suggestions to make the tests more reliable.
Comment on lines
+73
to
+85
| // The slug field runs an async uniqueness check; the form's | ||
| // `isValid` stays false while it's in flight, so wait for the | ||
| // REST call to settle before submitting. | ||
| await Promise.all( [ | ||
| page.waitForResponse( | ||
| ( resp ) => | ||
| resp.url().includes( `/${ TAXONOMIES_REST_BASE }?` ) && | ||
| resp.url().includes( 'slug=genre' ) | ||
| ), | ||
| page | ||
| .getByRole( 'textbox', { name: 'Taxonomy key' } ) | ||
| .fill( 'genre' ), | ||
| ] ); |
Member
There was a problem hiding this comment.
This feels a bit fragile; should we do something like this instead:
Suggested change
| // The slug field runs an async uniqueness check; the form's | |
| // `isValid` stays false while it's in flight, so wait for the | |
| // REST call to settle before submitting. | |
| await Promise.all( [ | |
| page.waitForResponse( | |
| ( resp ) => | |
| resp.url().includes( `/${ TAXONOMIES_REST_BASE }?` ) && | |
| resp.url().includes( 'slug=genre' ) | |
| ), | |
| page | |
| .getByRole( 'textbox', { name: 'Taxonomy key' } ) | |
| .fill( 'genre' ), | |
| ] ); | |
| await page.getByRole( 'textbox', { name: 'Taxonomy key' } ).fill( 'genre' ); | |
| await expect( page.getByRole( 'button', { name: 'Create' } ) ).toBeEnabled(); |
Contributor
Author
There was a problem hiding this comment.
We can't do that because the button doesn't get disabled/busy based on the form's validity. I've added a todo though to explore that. I didn't do it for now because I had tried that recently in quick edit action for posts and there were some nuances (especially with the slug field). I'll explore though in this form separately, because we might not have similar nuances.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
First e2e tests for the Taxonomies experiment.