Skip to content

Testing: Remove condition from 'autosave' e2e test#77829

Open
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:fix/failing-tests-58959
Open

Testing: Remove condition from 'autosave' e2e test#77829
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:fix/failing-tests-58959

Conversation

@im3dabasia
Copy link
Copy Markdown
Contributor

@im3dabasia im3dabasia commented Apr 30, 2026

What?

Closes #58959

Removes the conditional assertion and early return from the "shouldn't conflict with server-side autosave" e2e test.

Why?

  • The test contained a FIXME workaround that masked an intermittent issue where server-provided autosave values were occasionally unavailable after reload.
  • By removing the conditional escape hatch, the test is now deterministic and properly validates autosave behavior without hiding potential problems.

How?

Removed the stillHasRemoteAutosave variable check.

Testing Instructions

  1. Run the autosave e2e tests: npm run test:e2e -- test/e2e/specs/editor/various/autosave.spec.js
  2. All tests should pass without errors

Result

  • All tests pass without errors.
  • While the root cause of the original intermittent issue remains unknown, removing the conditional has not introduced any failures, which indicates the issue was either rare or has been resolved in the current codebase.

@im3dabasia im3dabasia changed the title fix: Remove condition from 'autosave' e2e test Testing: Remove condition from 'autosave' e2e test Apr 30, 2026
@im3dabasia im3dabasia self-assigned this Apr 30, 2026
@im3dabasia im3dabasia added [Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 30, 2026
@im3dabasia im3dabasia marked this pull request as ready for review April 30, 2026 08:39
@im3dabasia im3dabasia requested a review from Mamaduka April 30, 2026 08:39
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia im3dabasia removed the [Type] Bug An existing feature does not function as intended label Apr 30, 2026
@Mamaduka
Copy link
Copy Markdown
Member

Hm, not sure about this, test becomes flaky, and there's an annotated failure. That was the main reason I had to introduce the condition.

Try re-running it multiple times locally for testing.

Screenshot

CleanShot 2026-04-30 at 12 41 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Saving Related to saving functionality [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: Remove condition from 'autosave' e2e test

2 participants