Playlist Track: Show upload spinner inline - #81445
Draft
scruffian wants to merge 1 commit into
Draft
Conversation
|
Size Change: +243 B (0%) Total Size: 7.71 MB 📦 View Changed
|
scruffian
force-pushed
the
scruffian/fix/playlist-loader
branch
from
August 11, 2026 16:46
66fe0de to
0061ebd
Compare
|
Flaky tests detected in 0061ebd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/31514184821 As a user I want to be able to add multiple close buttons so that users can close the overlay from different positions in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the Playlist Track upload loading indicator so it appears inline with the uploaded track row instead of on the line above it.
Why?
The spinner was rendered as a sibling before the full-width track button, which caused it to sit on its own line during uploads.
How?
The spinner now renders inside the track button's flex row with scoped spacing, and the existing temporary blob upload unit test verifies the inline placement.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
N/A.
Use of AI Tools
Created with assistance from OpenAI Codex. The changes and tests were reviewed and run locally before opening this PR.
Checks run:
npm run test:unit packages/block-library/src/playlist-track/test,npm run lint:js -- packages/block-library/src/playlist-track/edit.js packages/block-library/src/playlist-track/test/edit.js,npm run lint:css -- packages/block-library/src/playlist-track/style.scss, andgit diff --check.