Playlist: Disable waveform player auto-init - #81489
Open
scruffian wants to merge 2 commits into
Open
Conversation
|
Size Change: +3.72 kB (+0.05%) Total Size: 7.72 MB 📦 View Changed
|
scruffian
marked this pull request as ready for review
August 12, 2026 10:18
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Aug 12, 2026
| '1.5x', | ||
| '1.75x', | ||
| '2x', | ||
| ]; |
Contributor
Author
There was a problem hiding this comment.
We don't need this because waveform player now validates this array.
scruffian
force-pushed
the
scruffian/fix/waveform-autoinit
branch
from
August 12, 2026 10:34
df2e2ab to
a60995d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #81342.
Updates
@arraypress/waveform-playerto 1.26.0, uses its document-level auto-init opt-out before Gutenberg imports the dependency, and sanitizes custom SVG icons passed through the Playlist waveform utility.Why?
The dependency's import-time scan can claim waveform markup before the Playlist block initializes what it owns, and custom icon markup should be cleaned at Gutenberg's boundary before it reaches the player.
How?
Adds a pre-import document attribute guard, restores any previous attribute value after import, allowlists SVG icon elements and attributes before writing
data-play-icon/data-pause-icon, and removes the old 1.23.0 patch-package patch.Testing Instructions
Run:
Testing Instructions for Keyboard
No keyboard-specific UI behavior changed.
Screenshots or screencast
N/A
Use of AI Tools
This PR was authored with help from ChatGPT/Codex and reviewed by the contributor.