Skip to content

fix for issue #3817 -- add visual regression test for sketchfab result #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sTarunRaaj
Copy link

Fixes

Fixes #3817 by @dhruvkb

Description

Adds a visual regression test for a known Sketchfab 3D model result page: /image/da5cb478-c093-4d62-b721-cda18797e3fb.

This test ensures that the Sketchfab embedded viewer renders correctly on the single result page across different breakpoints and language directions (LTR/RTL). It helps catch future layout or rendering regressions that could affect the 3D viewer.

The test was added to the existing pages-single-result.spec.ts file using Playwright's snapshot comparison.

Testing Instructions

  1. Run the test: pnpm test:e2e --grep "Sketchfab"
  2. Confirm that a snapshot is generated in the appropriate __snapshots__ directory.
  3. Verify that the iframe loads and the page renders as expected before the screenshot is taken.
  4. Optionally modify layout/CSS and re-run to confirm visual diff detection.

Checklist

  • Descriptive PR title
  • Targets main branch
  • Commit messages follow best practices
  • Code follows project style
  • Test added for the change
  • Documentation updated (not applicable)
  • Project runs locally without errors
  • DAG or API docs generated (not applicable)

@sTarunRaaj sTarunRaaj requested a review from a team as a code owner April 25, 2025 17:57
@sTarunRaaj sTarunRaaj requested review from obulat and dhruvkb April 25, 2025 17:57
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🤖 aspect: dx Concerns developers' experience with the codebase labels Apr 25, 2025
@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 👀 Needs Review
Development

Successfully merging this pull request may close these issues.

Add visual regression test for single Sketchfab result
2 participants