Fix negative audio duration in API#5572
Open
coderGtm wants to merge 3 commits into
Open
Conversation
If the duration is negative, it is set as None
Handle duration as None if it's negative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #5420 by @alfieatkinson
Description
The Wikimedia Commons API is returning a negative float for the duration of a particular OGG file (likely -1.012 seconds), which is a metadata anomaly in the source file. The code blindly converts it to milliseconds: int(-1.012 * 1000) = -1012. This negative value then passes through
_validate_integerinMediaStorewithout being caught.This PR clamps a negative duration to None since a sub-zero duration is physically meaningless.
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin