Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Server-Timing implementation to support new Chrome DevTools Performance Panel integration #1578

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ensure triggering action in tests does not cause side effects from ca…
…llbacks.
felixarntz committed Oct 4, 2024
commit 946c4fd0a3ae33783ad48d8c372a449b714c45a6
Original file line number Diff line number Diff line change
@@ -48,6 +48,7 @@ public function test_set_value_prevents_late_measurement(): void {
$this->setExpectedIncorrectUsage( Perflab_Server_Timing_Metric::class . '::set_value' );

$this->metric->set_value( 2 );
remove_all_actions( 'perflab_server_timing_send_header' );
do_action( 'perflab_server_timing_send_header' );
$this->metric->set_value( 3 );

@@ -80,6 +81,7 @@ public function test_set_start_value_prevents_late_measurement(): void {
$this->setExpectedIncorrectUsage( Perflab_Server_Timing_Metric::class . '::set_start_value' );

$this->metric->set_start_value( 2 );
remove_all_actions( 'perflab_server_timing_send_header' );
do_action( 'perflab_server_timing_send_header' );
$this->metric->set_start_value( 3 );