Run unit tests only for plugins with changes #1838
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ on: | |
| - '**/package.json' | ||
| - 'package-lock.json' | ||
| - 'phpunit.xml.dist' | ||
| - 'tools/phpunit/bootstrap.php' | ||
| - 'composer.json' | ||
| - 'composer.lock' | ||
| pull_request: | ||
|
|
@@ -24,6 +25,7 @@ on: | |
| - '**/package.json' | ||
| - 'package-lock.json' | ||
| - 'phpunit.xml.dist' | ||
| - 'tools/phpunit/bootstrap.php' | ||
| - 'composer.json' | ||
| - 'composer.lock' | ||
| types: | ||
|
|
@@ -57,6 +59,55 @@ jobs: | |
| steps: | ||
| - uses: styfle/[email protected] | ||
| - uses: actions/checkout@v4 | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v45 | ||
| with: | ||
| dir_names: true # Output unique changed directories. | ||
| dir_names_max_depth: 2 | ||
| files_yaml: | | ||
| plugins: | ||
| - 'plugins/**' | ||
| config: | ||
| - '.github/workflows/php-test-plugins.yml' | ||
| - '.wp-env.json' | ||
| - '**/package.json' | ||
| - 'package-lock.json' | ||
| - 'phpunit.xml.dist' | ||
| - 'tools/phpunit/bootstrap.php' | ||
| - 'composer.json' | ||
| - 'composer.lock' | ||
| - name: Get changed plugins | ||
| id: changed-plugins | ||
| run: | | ||
| if [[ "${{ github.event_name }}" == "push" || "${{ steps.changed-files.outputs.config_any_changed }}" == "true" ]]; then | ||
| ALL_CHANGED_PLUGINS=($(ls plugins)) | ||
| echo "all_changed_plugins=${ALL_CHANGED_PLUGINS[*]}" >> $GITHUB_OUTPUT | ||
| exit 0 | ||
| fi | ||
|
|
||
| declare -a ALL_CHANGED_PLUGINS=() | ||
| for DIR in ${{ steps.changed-files.outputs.plugins_all_changed_files }}; do | ||
| PLUGIN_NAME=$(basename "$DIR") | ||
| ALL_CHANGED_PLUGINS+=("$PLUGIN_NAME") | ||
| done | ||
|
|
||
| # Define and add plugin dependents (e.g., changes to Optimization Detective should trigger its dependents). | ||
| declare -A PLUGIN_DEPENDENTS=( | ||
| ["optimization-detective"]="embed-optimizer image-prioritizer" | ||
| ) | ||
| for PLUGIN in "${ALL_CHANGED_PLUGINS[@]}"; do | ||
| if [[ -n "${PLUGIN_DEPENDENTS[$PLUGIN]}" ]]; then | ||
| for DEP in ${PLUGIN_DEPENDENTS[$PLUGIN]}; do | ||
| if [[ ! " ${ALL_CHANGED_PLUGINS[*]} " =~ " ${DEP} " ]]; then | ||
| ALL_CHANGED_PLUGINS+=("$DEP") | ||
| fi | ||
| done | ||
| fi | ||
| done | ||
|
|
||
| ALL_CHANGED_PLUGINS=($(echo "${ALL_CHANGED_PLUGINS[@]}" | tr ' ' '\n' | sort | tr '\n' ' ')) | ||
| echo "all_changed_plugins=${ALL_CHANGED_PLUGINS[*]}" >> $GITHUB_OUTPUT | ||
| - name: Setup Node.js (.nvmrc) | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
|
|
@@ -88,48 +139,70 @@ jobs: | |
| - name: Running single site unit tests | ||
| run: | | ||
| if [ "${{ matrix.coverage }}" == "true" ]; then | ||
| for PLUGIN in ${{ steps.changed-plugins.outputs.all_changed_plugins }}; do | ||
| npm run test-php:$PLUGIN -- -- -- --coverage-clover=./single-site-reports/coverage-$PLUGIN.xml | ||
| done | ||
| else | ||
| for PLUGIN in ${{ steps.changed-plugins.outputs.all_changed_plugins }}; do | ||
| npm run test-php:$PLUGIN | ||
| done | ||
| fi | ||
| - name: Running multisite unit tests | ||
| run: | | ||
| if [ "${{ matrix.coverage }}" == "true" ]; then | ||
| for PLUGIN in ${{ steps.changed-plugins.outputs.all_changed_plugins }}; do | ||
| npm run test-php-multisite:$PLUGIN -- -- -- --coverage-clover=./multisite-reports/coverage-multisite-$PLUGIN.xml | ||
| done | ||
| else | ||
| for PLUGIN in ${{ steps.changed-plugins.outputs.all_changed_plugins }}; do | ||
| npm run test-php-multisite:$PLUGIN | ||
| done | ||
| fi | ||
| - name: Download Codecov CLI | ||
| if: ${{ matrix.coverage == true }} | ||
| run: | | ||
| # Create a temporary directory for GPG operations | ||
| mkdir -p .gpg | ||
|
|
||
| curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --homedir .gpg --no-default-keyring --keyring trustedkeys.gpg --import | ||
| curl -Os https://cli.codecov.io/latest/linux/codecov | ||
| curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM | ||
| curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig | ||
| gpg --homedir .gpg --no-default-keyring --keyring trustedkeys.gpg --verify codecov.SHA256SUM.sig codecov.SHA256SUM | ||
| shasum -a 256 -c codecov.SHA256SUM | ||
| chmod +x codecov | ||
| - name: Upload coverage reports to Codecov | ||
| if: ${{ matrix.coverage == true }} | ||
| run: | | ||
| # Build common arguments for all uploads | ||
| cc_args=() | ||
| cc_args+=(--fail-on-error) | ||
| cc_args+=(--disable-search) | ||
| cc_args+=(--git-service github) | ||
| cc_args+=(--gcov-executable "gcov") | ||
|
|
||
| # Add SHA for PRs | ||
| if [ -n "${{ github.event.pull_request.head.sha }}" ]; then | ||
| cc_args+=(--sha "${{ github.event.pull_request.head.sha }}") | ||
| fi | ||
|
|
||
| # Handle authentication differently for forks vs. internal PRs | ||
| if [ -n "${{ github.event.pull_request.head.repo.full_name }}" ] && \ | ||
| [ "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]; then | ||
| echo "::notice::Processing PR from fork - using tokenless upload with branch override." | ||
| cc_args+=(--branch "${{ github.event.pull_request.head.label }}") | ||
| else | ||
| echo "::notice::Processing internal PR or push - using token." | ||
| cc_args+=(--token "${{ secrets.CODECOV_TOKEN }}") | ||
| fi | ||
|
|
||
| # Upload reports for each changed plugin | ||
| for PLUGIN in ${{ steps.changed-plugins.outputs.all_changed_plugins }}; do | ||
| echo "::group::Uploading coverage for plugin: $PLUGIN" | ||
| ./codecov upload-coverage "${cc_args[@]}" \ | ||
| --file ./single-site-reports/coverage-$PLUGIN.xml \ | ||
| --file ./multisite-reports/coverage-multisite-$PLUGIN.xml \ | ||
| --flag $PLUGIN \ | ||
| --name $PLUGIN-coverage | ||
| echo "::endgroup::" | ||
| done | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,45 @@ coverage: | |
| target: auto | ||
| threshold: 80% | ||
| base: auto | ||
| branches: | ||
| - trunk | ||
| informational: true | ||
| patch: | ||
| default: | ||
| threshold: 20% | ||
| informational: true | ||
| comment: | ||
| hide_comment_details: true | ||
| hide_project_coverage: false | ||
| show_carryforward_flags: true | ||
|
There was a problem hiding this comment. @westonruter Would you prefer that we display the carried forward flags in the PR comment, as shown below, or would you rather exclude them?
There was a problem hiding this comment. I suppose it doesn't hurt to include? |
||
| flag_management: | ||
| default_rules: | ||
| carryforward: true | ||
| individual_flags: | ||
| - name: auto-sizes | ||
| paths: | ||
| - plugins/auto-sizes/ | ||
| - name: dominant-color-images | ||
| paths: | ||
| - plugins/dominant-color-images/ | ||
| - name: embed-optimizer | ||
| paths: | ||
| - plugins/embed-optimizer/ | ||
| - name: image-prioritizer | ||
| paths: | ||
| - plugins/image-prioritizer/ | ||
| - name: optimization-detective | ||
| paths: | ||
| - plugins/optimization-detective/ | ||
| - name: performance-lab | ||
| paths: | ||
| - plugins/performance-lab/ | ||
| - name: speculation-rules | ||
| paths: | ||
| - plugins/speculation-rules/ | ||
| - name: web-worker-offloading | ||
| paths: | ||
| - plugins/web-worker-offloading/ | ||
| - name: webp-uploads | ||
| paths: | ||
| - plugins/webp-uploads/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This limits the directory output to a maximum depth of 2. For example,
plugins/<plugin-name>/testswill be returned asplugins/<plugin-name>.Since
dir_names: trueensures only unique directories are listed, combining it withdir_names_max_depth: 2allows us to extract a clean list of changed plugin names. This avoids additional logic in the next step for determining modified plugins.